My immediate thought here: this really screws with civil rights.
I would agree with that. FDR would be lazier on it. Eisenhower as a Democrat would have minimal motive to not be lazy.
The big elephant in the room is how the Korean War would go under Eisenhower. I personally don’t know enough about the Korean War or battle strategy to say but how it goes will determine whether he gets elected again in 52
Eisenhower as former Supreme Allied Commander has a *lot* of latitude to handle things differently.
First off, we haven't even considered yet if the early Cold War, blow-by-blow has gone exactly the same in the final FDR years, 1945-48 as it went in the Truman years. For instance, did we have the Greco-Turkish aid program, Marshall Plan, aid to Yugoslavia, NATO, and Berlin Blockade? What about Palestine partition and the 1st Arab-Israeli war?
Since we haven't discussed it, I guess we have to assume it is all the same. I think it is pretty reasonable to assume pretty much everything in the Chinese Civil War is going the same, that is far more subject to internal trends and less amenable to international moves than say, events in Germany or Greece.
So we're basically assuming Eisenhower inherits the same global situation, and military situation, that Truman inherited in OTL.
So that means Nationalist China is going down in his first year in office, and the Soviets are getting their A-Bomb around the same time. He'll get crap from this but it won't be too personal because it will be recognized he inherited it. Watching the process won't endear Chiang Kai-shek to him so odds are he won't favor getting involved in the Taiwan Straits (plus he'll be getting advice from Acheson and not Dulles) [Although he may be willing to clean house, but not sure who else he could grab on the Democratic bench if he ditches Acheson, he could go bipartisan if nominal Republicans are OK working for a nominally Democratic POTUS]
Now will Stalin (and Mao) let Kim off the leash in Korea? Maybe, maybe not. Probably so, but the US President being a familiar WWII militay man may give a deterrent edge to what was a knife's edge decision. So maybe there won't be a Korean War.
Eisenhower would be appalled at the state of military readiness across the services, even if he's no advocate of reliance on ground power and prefers primarily air and nuclear based deterrence.
If there is a Korean War, Eisenhower will be getting the same grand strategic and diplomatic advice about having to fight there, that Truman got. But he''ll also be getting the military advice and evaluations saying Korea itself is not strategically important and that the Communist move could be diversionary. He would also see that he would have to rely on MacArthur as his theater commander and likely see that as a negative.
As former Supreme Allied Commander, he could have the freedom to take a pass on fighting for Korea based on his military judgment and the judgment of the JCS, even while condemning the aggression, stepping up defense spending, and strengthening global US defense posture. This could include, or leave out, interposing the 7th fleet in the Taiwan straits. The JCS was saying it wasn't that easy or practical, but at the same time, compared with a ground war in East Asia, it is patently easier.
But the bottom-line is he could get through his term avoiding the Korean War or setting precedents for committing US ground forces to Asia or undeclared wars (so also avoiding commitment to directly fight in Indochina) while building up US strategic airpower and NATO forces.
He'll take criticism, and control of Congress, or one house of it, may flip in '50, but his reelection likely wouldn't be sunk and it would be dependent on the appeal and charisma of his opponent and the state of the economy. With a probable upswing in the economy, Republicans in Congress doing some unpopular things, and a probable rematch with Taft, his reelection chances should be decent despite foreign policy failures in Asia in the rear view mirror by '52.
By '56 the Democrats will be out of schlitz, Taft will be safely dead, and the Republican nominee, be it Warren, Bricker, or Nixon, will be younger and add a little more sizzle and they will add some more Kennedy-esque promise of energizing and 'winning' in foreign policy to contrast with the lethargic Eisenhower, and it should work well for them against whatever Democratic palooka is stuck with the nomination that year. Hopefully by then the French will have surrendered all of Indochina so that America cannot end up getting caught in a ground or nuclear war there as the GOP young Turk jumps up to prove himself. And the GOP Young Turk's presidency should be safely after the Hungarian revolt is over, so he can stay out of too serious trouble.