Cult of the Sun was on the rise since the reign of Septimius Severus and those Syrian women, and Elagabalus managed to keep it four years because in that odd dancings he offered free food to the masses, as simple as that. Even some of the senators participated in such things.
Not 4 years, Elagabalus truly seized power only once Macrinus was killed in late 218, only in his journey to Rome he’d face revolts by the III Gallica and the IV Schytica, ironically the very legions that ensured his victory over Macrinus, which he had left in Syria, then by legions in Nicomedia led by Caius Castinus Septimius and by legions on the Danubian frontier led by Triccianus, one of Macrinus’ adherents. All this significantly slowed him down so that he would reach Rome in middle 219 and die in March 222, thus little less than three years.
None of the senators were happy to participate, in fact, in one of the rarest occurences in Roman history, when Elagablus asked the Senate to take away the rank of Caesar from Alexander, which he himself had granted him, all senators refused, all of them. No emperor before had ever been defied this way. There’s nothing more telling than that.
As for the people, there were way less outlandish ways to distribute congiaria, apparently Elagabalus would throw live animals from his palace, and some people died because of that. I think they’d rather have a more traditional emperor who gave them food the traditional way.
Elagabalus was killed mostly because he was truely incompetent managing the praetorians and the soldiers, and they revolted against him. I think if he would have been wiser keeping the praetorians and soldiers happy with gifts and privileges, his reign would have lasted longer and the masses would be happy receinving free food while dancing around that stupid rock.
The pretorians were paid handsomely by Julia Moesa, that wasn’t the issue. When they first assaulted Elagabalus, in late 221, they imposed several things on him, most importantly to get rid of his low born confidants, asecond, to behave like a decent Roman and third, to not touch Alexander with one finger. There was no request for additional pay, the Pretorians could be bought, but they still had dignitas, and their emperor was ashaming the whole empire with his attitude.