This was a tough call. In favor of waiting:
1) The longer the Japanese wait to attack south, the stronger the US, Britain and the NEI get relative to the Japanese--as long as the Soviets hold out.
2) The US and Britain correctly saw the Germans as the main enemy and the Japanese as a lesser threat and a distraction from the really serious enemy.
3) If the Japanese successfully attacked south, they would gain control of over 90% of the world rubber supply. That turned out not to be crucial because the US managed to put together a synthetic rubber industry before rubber stockpiles ran low. However, we didn't know that building a synthetic rubber industry from scratch would be possible in summer 1941.
The problems with waiting:
1) The Japanese might tackle the Soviets in Manchuria. That's not the most likely outcome, but we didn't know that at the time. The oil embargo pretty much made going North impossible for the Japanese--but also lit a fuse. The Japanese were either going to surrender or attack at least the British and NEI, and given the Japanese national character, attack to the south was pretty much inevitable once the embargo was imposed. A Japanese attack on the Soviets may or may not have shifted the course of the Soviet/German war, but whichever way it actually would have gone, US policymakers couldn't be certain based on what they knew as to whether a Japanese pile-on would be the last straw for Soviet resistance.
2) It's possible that the Japanese would have attack south in December 1941 anyway, in which case they would simply have several months additional oil supply. However, the US had a way of detecting the likelihood of that. If the Japanese decided to head south, Japanese merchant ships would head for home waters, as they did historically in the summer of 1941. The merchant ships were vital to the Japanese ability to wage war, and getting them home took months, especially if the US encountered mysterious difficulties getting them through the Panama canal, as they did historically.
3) It is possible that the Japanese would have take the opportunity to finish off the Nationalist Chinese in late 1941/42, as noted above, but the Burma road probably would have helped stave that off, as also noted above.
The embargo wasn't a foregone conclusion, and my understanding is that Roosevelt intended for it to be limited rather than total but was put in a position where he had to either make it total or look like he was going soft by harder-line underlings.