IIRC, the effects were rather more of a propagandistic nature than actually materializing. By making the spread of luxuries such as holidays (in the extreme case, maritime cruises) and cars into the middle- and working class a political aim, it helped to create acceptance of the regime, especially during the late 30s when actually few Germans were complaining. And, as these programmes were new, waiting for them to fulfiil their promises was still OK (Germans are patient).
Of course, even for the Nazis, it was impossible to maintain these promises without actual economic growth. The outbreak of the war was a good excuse to postpone all these aims until the Endsieg.
Without a war, the inherent problems would have shown rather soon:
a) the priority given to party members when it came to the goodies...
b) the costs. For example, the payment scheme for the KdF-Wagen (the later Volkswagen "Bug", yes) aimed at saving up to 995 RM. But - this was not a cost-effective prize. For real, the money was swallowed up for the war effort and very few of the cars reached customers. Without war, the price would have to rise (also for the planned 4-door-variation), destroying the promise for the working class, or the cost-difference would have to be paid by the Reich. And the Reich's finances under Hitler....you would have to search hard to find a nastier can of worms.