Suppose General Luna, probably the best military leader in Philippine history, survives his assassination attempts, and successfully manages to make a greater impact on the Philippine-American War. What would the repercussions and effects be on the Philippines from that event up to modern day?
End result would be the same losing to the USA. The greatest impact Luna could have made was before the Spanish surrendered Manila to the USA.
Strategically holding Manila denies US a port for the US army to disembark unmolested. US not holding Manila could butterfly how Washington would view the situation on their decision to colonize the Philippines.
If we entertain what you say, Luna surviving wont change the situation what the state Philippine army was. You got political appointees in the Army due to loyalty to Aquinaldo. Some of these are alien to western military style of discipline, and view it as harsh, rude. While in paper Luna was total control, he wasnt de facto in total control. In certain battles in OTL Luna actually spent time trying to discipline Aguinaldo appointed soldiers while the Americans were advancing.
You may say that would be the same in taking Manila. But, taking Manila requires only a specialized professional force, like Luna's Sharpshooters, which western military tactics, or discipline isnt alien to the soldiers, officers. While trying to beat the US in guerrilla warfare or conventional warfare requires every soldier, officer to follow Luna including political appointees in the military and soldiers who are unaware of western military tactics or discipline.